Skip to content

Cherry-pick Redshift dialect to our branch #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovr merged 2 commits into from
Sep 20, 2022
Merged

Cherry-pick Redshift dialect to our branch #28

ovr merged 2 commits into from
Sep 20, 2022

Conversation

@ovr
Copy link
Member

@ovr ovr commented Sep 20, 2022

No description provided.

mskrzypkows and others added 2 commits September 20, 2022 13:03
@mskrzypkows @alamb @ovr
Add Redshift dialect, handle square brackets properly (apache#471)
8824d15 
* Redshift square bracket handling

We need to detect `[` or `"` for Redshift quotes around indentifier and at the same time exclude
treating JSON paths as indentifer

* RedshiftSqlDialect documentation update

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

* Renamed _chars to chars

* Fixed warnings

* Missing license

Co-authored-by: Maciej Skrzypkowski <maciej.skrzypkowski@satoricyber.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@yuval-illumex @ovr
Redshift - Add support in sharp as start of the field name (apache#485)
64d671b 
* Add support in sharp

* CR Review
@coveralls
Copy link

coveralls commented Sep 20, 2022

Pull Request Test Coverage Report for Build 3089226923

  • 68 of 72 (94.44%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 85.19%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/dialect/mod.rs 1 2 50.0%
src/dialect/redshift.rs 11 12 91.67%
src/tokenizer.rs 4 5 80.0%
tests/sqlparser_redshift.rs 52 53 98.11%
Totals Coverage Status
Change from base Build 3084303997: 0.06%
Covered Lines: 8766
Relevant Lines: 10290
💛 - Coveralls

@ovr ovr merged commit 84c33b6 into cubesql-v0.16.0 Sep 20, 2022
@ovr ovr deleted the fork-redshift-cherry-pick branch September 20, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ovr @coveralls @mskrzypkows @yuval-illumex